refactor(eventsub): enforce static error categories #5903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pop quiz: is there a requirement for the
error_category
passed to theerror_code
constructor (docs)?Doesn't look like it.
boost::system::error_category
doesn't say anything either (maybe I missed something). Well, turns out,error_category
instances are treated like singletons. So we shouldn't construct them at runtime. One additional constraint we'd like to enforce is that they're supposed to be constant initialized (without the implicit lock inserted by the compiler forstatic
s). We can achieve both of these by constructing a single global instance of the category and by usingstd/boost::source_location
.Initially, I had some funky workarounds for not being able to pass strings through the code (first commit). However, I realized that the location in the file where an error was emitted from contains the same (if not more) information. This is also simpler, because it's encouraged by
boost::system::error_code
.