Skip to content

Commit

Permalink
Profiling has a runtime error with current rust, remove this for now …
Browse files Browse the repository at this point in the history
…(was part of dev branch)
  • Loading branch information
prozacchiwawa committed Jul 15, 2024
1 parent 732c9e5 commit 22741cb
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 70 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ jobs:
run: |
cargo install grcov
rustup component add llvm-tools-preview
python ./resources/coverage/run_coverage.py --require-percent 60 --test-args="--features=profiling"
python ./resources/coverage/run_coverage.py --require-percent 60 --test-args="--features="
- name: Build alpine wheel via docker
if: startsWith(matrix.os, 'ubuntu') && startsWith(matrix.python, '3.8')
Expand Down
53 changes: 5 additions & 48 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ rand = "0.8.5"
rand_chacha = "0.3.1"

[dependencies.pprof]
version = "0.23.0"
version = "0.12"
features = ["flamegraph"]
optional = true

Expand Down
19 changes: 0 additions & 19 deletions src/classic/clvm_tools/cmds.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ use crate::classic::clvm_tools::debug::{
trace_to_text,
};
use crate::classic::clvm_tools::ir::reader::read_ir;
#[cfg(feature = "profiling")]
use crate::classic::clvm_tools::profiling::Profiler;
use crate::classic::clvm_tools::sha256tree::sha256tree;
use crate::classic::clvm_tools::stages;
use crate::classic::clvm_tools::stages::stage_0::{
Expand Down Expand Up @@ -1078,13 +1076,6 @@ pub fn launch_tool(stdout: &mut Stream, args: &[String], tool_name: &str, defaul
.set_type(Rc::new(OperatorsVersion {}))
.set_default(ArgumentValue::ArgInt(OPERATORS_LATEST_VERSION as i64)),
);
#[cfg(feature = "profiling")]
parser.add_argument(
vec!["--profiling".to_string()],
Argument::new()
.set_action(TArgOptionAction::StoreTrue)
.set_help("Run with profiling".to_string()),
);

if tool_name == "run" {
parser.add_argument(
Expand Down Expand Up @@ -1112,16 +1103,6 @@ pub fn launch_tool(stdout: &mut Stream, args: &[String], tool_name: &str, defaul
return;
}

#[cfg(feature = "profiling")]
let _profiler = if matches!(
parsed_args.get("profiling"),
Some(ArgumentValue::ArgBool(true))
) {
Some(Profiler::new("prof.svc"))
} else {
None
};

let empty_map = HashMap::new();
let keywords = match parsed_args.get("no_keywords") {
Some(ArgumentValue::ArgBool(_b)) => &empty_map,
Expand Down
1 change: 0 additions & 1 deletion src/classic/clvm_tools/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,5 @@ pub mod debug;
pub mod ir;
pub mod node_path;
pub mod pattern_match;
mod profiling;
pub mod sha256tree;
pub mod stages;

0 comments on commit 22741cb

Please sign in to comment.