-
-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added opt-in features #7652
Open
glen-84
wants to merge
8
commits into
main
Choose a base branch
from
gai/opt-in-features
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added opt-in features #7652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7652 +/- ##
==========================================
+ Coverage 74.05% 74.13% +0.07%
==========================================
Files 2920 2931 +11
Lines 151493 151920 +427
Branches 17614 17661 +47
==========================================
+ Hits 112194 112622 +428
+ Misses 33445 33435 -10
- Partials 5854 5863 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/HotChocolate/Core/src/Types/Configuration/Validation/RequiresOptInValidationRule.cs
Show resolved
Hide resolved
src/HotChocolate/Core/src/Types/Types/Directives/OptInFeatureStabilityDirectiveExtensions.cs
Show resolved
Hide resolved
glen-84
added
the
🍒 cherry-pick
Consider cherry-picking these changes into the previous major version.
label
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🍒 cherry-pick
Consider cherry-picking these changes into the previous major version.
🌶️ hot chocolate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Closes #7720
❓ Questions:
ErrorHelper.cs
.📓 Spec notes:
*
*
includeOptIn
instead ofincludeRequiresOptIn
for introspection, as it seemed more clear, WDYT?*
stability strings as well.