Azure Blob Storage as storage backend for Persisted Operations #7777
+888
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📚 documentation
|
Hey @cimnine thanks for your contribution. Tell us when you need a review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7777 +/- ##
=======================================
Coverage 74.32% 74.33%
=======================================
Files 2860 2864 +4
Lines 149842 149914 +72
Branches 17411 17421 +10
=======================================
+ Hits 111373 111439 +66
- Misses 32671 32674 +3
- Partials 5798 5801 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cimnine
force-pushed
the
AzureBlobStorage
branch
from
16298f8 to
686a709
Compare
|
@michaelstaib I believe now it would be ready for a first round of scrutiny. |
cimnine
force-pushed
the
AzureBlobStorage
branch
from
686a709 to
6e8df7e
Compare
|
@michaelstaib what are the next steps here? |
|
I will have a look today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a new adapter to use Azure Blob Storage as storage backend for (automatically) persisted operations.
At least on Azure, Redis-compatible cache instances are comparably costly and mounting a shared filesystem is not always possible – and often not desired either. The Blob Storage on the other end is almost free.
Also, it's relatively easy to upload persisted operations extracted from a client in a CI/CD pipeline, whereas this is tricky with the existing options.
Please let me know if you're interested in including this as an officially supported storage backend. Otherwise, I will probably publish it independently.