New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds support for async service scope in request executor #7826

Open

PascalSenn wants to merge 1 commit into main from pse/allow-async-service-scope

Member

PascalSenn commented Dec 13, 2024 •

edited

Loading

In case you add a service to the DI that only has implemented IAsyncDisposable you will get the following error:

'YourType' type only implements IAsyncDisposable. Use DisposeAsync to dispose the container.

Instead of creating a AsyncServiceScope on every resolver execution, it should be enough to just check if the scope implements IAsyncDisposable:
https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/src/AsyncServiceScope.cs


          adds support for async service scope in request executor

7f33226

github-actions bot added the 🌶️ hot chocolate label

michaelstaib added the 🍒 cherry-pick label

michaelstaib self-requested a review

December 13, 2024 21:35

michaelstaib added this to the HC-14.3.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍒 cherry-pick 🌶️ hot chocolate