Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DGL upstream API changes #214

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

m-atalla
Copy link

@m-atalla m-atalla commented Jul 6, 2023

Fixes #213

Changes Summary:

  • The pre-commit hooks were updated. The flake8 hook was updated to point to the new GitHub repository, as the previously linked GitLab repository was deleted. The isort hook was updated to version 5.12, as the old version caused an error reported here.
  • The dgl was updated to version 1.1.1, which in turn required an update to the psutil library to version 5.8.0.
  • updated to_dgl return types to DGLGraph .
  • added a couple of test to ensure my changes are working as intended.

Copy link
Owner

@ChrisCummins ChrisCummins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @m-atalla, thanks so much for this! These updates look great.

Unfortunately the CI is failing but for unrelated reasons (the runners have updated and so some package names need refreshing), but I see no reason for that to block landing this.

Cheers,
Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProGraML package breaks with recent DGL api changes
2 participants