Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct source sets for iOS #153

Merged
merged 2 commits into from
Nov 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Thank 🙏 you for your interest in contributing to this project! Please read th

The following steps will give a short guide on how to contribute to this project:

- Create a personal [fork](https://github.com/ChrisKruegerDev/tmdb-api/fork) of the project on [GitHub](https://github.com/).
- Create a personal [fork](https://github.com/ChrisKruegerDev/tmdb-kotlin/fork) of the project on [GitHub](https://github.com/).
- Clone the fork on your local machine. Your remote repo on [GitHub](https://github.com/) is called `origin`.
- Add the original repository as a remote called `upstream`.
- If you created your fork a while ago be sure to pull upstream changes into your local repository.
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
***Get movies and TV shows from the largest community database.***

[![Maven Central](https://img.shields.io/maven-central/v/app.moviebase/tmdb-api?label=Maven%20Central)](https://search.maven.org/artifact/app.moviebase/tmdb-api)
![Github Actions](https://github.com/ChrisKruegerDev/tmdb-api/actions/workflows/build.yml/badge.svg)
[![Issues](https://img.shields.io/github/issues/ChrisKruegerDev/tmdb-api)](https://github.com/ChrisKruegerDev/tmdb-api/issues)
![Github Actions](https://github.com/ChrisKruegerDev/tmdb-kotlin/actions/workflows/build.yml/badge.svg)
[![Issues](https://img.shields.io/github/issues/ChrisKruegerDev/tmdb-kotlin)](https://github.com/ChrisKruegerDev/tmdb-api/issues)
[![Kotlin](https://img.shields.io/badge/kotlin-2.0.21-blue.svg?logo=kotlin)](http://kotlinlang.org)
[![Gradle](https://img.shields.io/badge/Gradle-8-green?style=flat)](https://gradle.org)
[![GitHub License](https://img.shields.io/badge/license-Apache%20License%202.0-blue.svg?style=flat)](http://www.apache.org/licenses/LICENSE-2.0)
[![GitHub Account](https://img.shields.io/static/v1?label=GitHub&message=chrisnkrueger&color=C51162)](https://github.com/chrisnkrueger)
[![GitHub Account](https://img.shields.io/static/v1?label=GitHub&message=ChrisKruegerDev&color=C51162)](https://github.com/ChrisKruegerDev)

<hr>

Expand Down Expand Up @@ -210,7 +210,7 @@ val vimeoTmdbVideo = TmdbVideo(id = "123", key = "qwerasdf", site = TmdbVideoSit
val url = TmdbImageUrlBuilder.build(vimeoTmdbVideo) // It will return `https://vimeo.com/qwerasdf`
```
## Contributing 🤝
Please feel free to [open an issue](https://github.com/ChrisKruegerDev/tmdb-api/issues/new/choose) if you have any questions or suggestions. Or participate in the [discussion](https://github.com/ChrisKruegerDev/tmdb-api/discussions). If you want to contribute, please read the [contribution guidelines](https://github.com/ChrisKruegerDev/tmdb-api/blob/main/CONTRIBUTING.md) for more information.
Please feel free to [open an issue](https://github.com/ChrisKruegerDev/tmdb-kotlin/issues/new/choose) if you have any questions or suggestions. Or participate in the [discussion](https://github.com/ChrisKruegerDev/tmdb-kotlin/discussions). If you want to contribute, please read the [contribution guidelines](https://github.com/ChrisKruegerDev/tmdb-kotlin/blob/main/CONTRIBUTING.md) for more information.

<br>

Expand Down
43 changes: 30 additions & 13 deletions tmdb-api/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ kotlin {
browser()
nodejs()
}

listOf(
iosX64(),
iosArm64(),
Expand Down Expand Up @@ -71,28 +72,44 @@ kotlin {
val jsMain by getting
val jsTest by getting

val iosX64Main by getting
val iosArm64Main by getting
val iosSimulatorArm64Main by getting

val iosMain by creating {
iosX64Main.dependsOn(this)
iosArm64Main.dependsOn(this)
iosSimulatorArm64Main.dependsOn(this)
dependsOn(commonMain)

dependencies {
implementation(libs.ktor.darwin)
}
}

val iosX64Test by getting
val iosArm64Test by getting
val iosSimulatorArm64Test by getting
val iosX64Main by getting {
dependsOn(iosMain)
}

val iosArm64Main by getting {
dependsOn(iosMain)
}

val iosSimulatorArm64Main by getting {
dependsOn(iosMain)
}

val iosTest by creating {
iosX64Test.dependsOn(this)
iosArm64Test.dependsOn(this)
iosSimulatorArm64Test.dependsOn(this)
dependsOn(commonTest)

dependencies {
implementation(libs.ktor.darwin)
}
}

val iosX64Test by getting {
dependsOn(iosTest)
}

val iosArm64Test by getting {
dependsOn(iosTest)
}

val iosSimulatorArm64Test by getting {
dependsOn(iosTest)
}
}
}
Expand Down
Loading