Fixed some Rust code structure and modified the workflow to fail if c…

…lippy returns warnings (#569) * Fixed someone else's mistakes * workflow now fails if clippy returns warnings * refactor: Make base title variable constant --------- Co-authored-by: Liam <[email protected]>
ChrisTitusTech · Sep 21, 2024 · f2332a7 · f2332a7
1 parent 59744e8
commit f2332a7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -38,7 +38,7 @@ jobs:
           restore-keys: ${{ runner.os }}-cargo-index-
 
       - name: Run cargo clippy
-        run: cargo clippy
+        run: cargo clippy -- -Dwarnings
 
       - name: Run cargo fmt
         run: cargo fmt --all --check
diff --git a/tui/src/state.rs b/tui/src/state.rs
@@ -21,6 +21,7 @@ use ratatui::{
 
 const MIN_WIDTH: u16 = 77;
 const MIN_HEIGHT: u16 = 19;
+const TITLE: &str = concat!("Linux Toolbox - ", env!("BUILD_DATE"));
 
 pub struct AppState {
     /// Selected theme
@@ -243,11 +244,11 @@ impl AppState {
             Style::new()
         };
 
-        let title = format!(
-            "Linux Toolbox - {} {}",
-            env!("BUILD_DATE"),
-            self.multi_select.then(|| "[Multi-Select]").unwrap_or("")
-        );
+        let title = if self.multi_select {
+            &format!("{} [Multi-Select]", TITLE)
+        } else {
+            TITLE
+        };
 
         #[cfg(feature = "tips")]
         let bottom_title = Line::from(self.tip.bold().blue()).right_aligned();