Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a greater extent of mouse interaction within the tui #946

Closed

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Nov 13, 2024

Type of Change

  • Refactoring

Description

features included in this pr:

  • Allows for clicking entries with LMB (left mouse button)
  • Allows for navigating through individual entries via moving the mouse up and down instead of using the scroll wheel
  • Allows for selection of the search bar.
  • Allows for description interaction via pressing down on the scrollwheel
  • Allows for script preview interaction via RMB (Right Mouse Button)
  • Allows for click and drag meaning holding down LMB (left mouse button) and dragging the mouse up and down inside of either the descriptions or script previews
  • Allows for closing floating windows via RMB (right mouse button) only when a floating window is on screen for instance: descriptions, previews, confirmation, root check, and so on
  • Allows for confirmation prompt accepting via LMB (left mouse button) after LMB is pressed it will continue on and run the script, after the script finished RMB (right mouse button) can be pressed to then close the floating window

Missing features:

  • Scrolldown / Scroll up on last item / first item in list ( big issue on small windows where scrolldown is possible ), ( not to mention that it'll desync due to item padding. ) - > does not matter on bigger window sizes

closes #942
closes #936
closes #938

@ChrisTitusTech This PR Should be merged with: #937

Testing

tested
video is a little bit laggy, You are warned !!

2024-11-13.00-24-59.mp4

@nnyyxxxx nnyyxxxx marked this pull request as draft November 13, 2024 04:38
@nnyyxxxx nnyyxxxx changed the title w.i.p. concept for more mouse interaction within the tui w.i.p. implementation for more mouse interaction within the tui Nov 13, 2024
@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Nov 13, 2024

i would appreciate code review from @adamperkowski , @lj3954 , @cartercanedy , @afonsofrancof , and opinions as well.

For now this implementation is completed and the tui can now be fully controlled and navigated with the mouse, all features within this PR are stated in the description.

@nnyyxxxx nnyyxxxx changed the title w.i.p. implementation for more mouse interaction within the tui implement a greater extent of mouse interaction within the tui Nov 13, 2024
@nnyyxxxx nnyyxxxx marked this pull request as ready for review November 13, 2024 09:59
@nnyyxxxx nnyyxxxx force-pushed the concept_for_more_mouse_interaction branch 3 times, most recently from e3e4071 to e583fc7 Compare November 13, 2024 14:16
@adamperkowski adamperkowski added enhancement New feature or request UI/UX labels Nov 17, 2024
@nnyyxxxx nnyyxxxx force-pushed the concept_for_more_mouse_interaction branch from e583fc7 to eeb5014 Compare November 17, 2024 06:49
@nnyyxxxx nnyyxxxx marked this pull request as draft November 17, 2024 18:26
@nnyyxxxx nnyyxxxx closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tui is noticably laggy with mouse interaction
2 participants