Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #913 "feat: Mouse scroll" #942

Closed

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Nov 12, 2024

Reverts #913

@ChrisTitusTech this feature lags the tui and increases cpu usage by a crazy amount, i think this should be reverted.
debug: ( much worse )
image
release: ( a little better but still noticeable)
image

@ChrisTitusTech take a look at #936 for more information regarding the bugs that came with the merge of #913

closes #938
closes #937
closes #946
resolves #936
resolves #941
resolves #939

after merging this i think a new prerelease should be made IF this feature was included in the latest one.

Also to bake this up even more, I think tui's shouldn't have mouse interaction in the first place and I think you can agree with me on that one, BECAUSE It's ran in the terminal (1) It's too resource intensive to provide support for it (2), please consider merging this.

@ChrisTitusTech very important !! check out #946 it provides a major improvement towards this feature that includes more mouse interaction as seen in the video provided.

If you're not willing to merge this, take a look at :
#938
#937
#946

They both provide QOL improvements towards this feature.

If you still want to keep this feature inside of Linutil then this will have to be heavily optimized and I don't think It's possible.

@jeevithakannan2
Copy link
Contributor

Running a debug will have more CPU usage add a SS of running the pre-release

@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Nov 12, 2024

only a 3% difference, and the performance is about the same

image

@jeevithakannan2
Copy link
Contributor

jeevithakannan2 commented Nov 12, 2024

Please check with previous a old release before implementation of mouse scroll. I don't see any difference in CPU usage before and after #913

image
image

@nnyyxxxx
Copy link
Contributor Author

i already have

@adamperkowski adamperkowski changed the title Revert "feat: Mouse scroll" Revert #913 "feat: Mouse scroll" Nov 17, 2024
@adamperkowski adamperkowski added the bug Something isn't working label Nov 17, 2024
@nnyyxxxx nnyyxxxx marked this pull request as draft November 18, 2024 05:21
@nnyyxxxx nnyyxxxx closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants