Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter): prevent panic after tab completing #1026

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(filter): prevent panic after tab completing #1026

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de3d019
fix(filter): prevent panic after tab completing
nnyyxxxx Feb 12, 2025
8b04e8a
refactor(filter): reduce nesting in update_completion_preview fn
nnyyxxxx Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions tui/src/filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,23 @@ impl Filter {
}

fn update_completion_preview(&mut self) {
self.completion_preview = if self.items.is_empty() || self.search_input.is_empty() {
None
} else {
let input = self.search_input.iter().collect::<String>().to_lowercase();
self.items.iter().find_map(|item| {
let item_name_lower = item.node.name.to_lowercase();
(item_name_lower.starts_with(&input))
.then_some(item_name_lower[input.len()..].to_string())
})
if self.items.is_empty() || self.search_input.is_empty() {
self.completion_preview = None;
return;
}

let input = self.search_input.iter().collect::<String>().to_lowercase();

let completion = self
.items
.iter()
.find(|item| item.node.name.to_lowercase().starts_with(&input))
.and_then(|item| {
let name = item.node.name.to_lowercase();
(input.len() <= name.len()).then(|| name[input.len()..].to_string())
});

self.completion_preview = completion;
}

pub fn draw_searchbar(&self, frame: &mut Frame, area: Rect, theme: &Theme) {
Expand Down
Loading