-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the weight of the produced binary for faster start time #178
Reduce the weight of the produced binary for faster start time #178
Conversation
Optimise for weight at the expense of compile time, speed and we strip debuging elements Signed-off-by: Soapydev <[email protected]>
I still think it's very weird for the user of #170's pc to take 10 seconds for two simple curl commands. I think we should prioritize performance until the binary size gets too big. |
Signed-off-by: Soapydev <[email protected]>
I agree that it's strange. On the other hand, I do think that its well established that Linux breath a second life in older hardware, so many users might still be using an old, dare I say, ancient machine. For new comers in the Linux world, I think its a risk free entry to dust off an old laptop and test it out there. So, in that regard, I think we could address this right now. Keeping the opt-level as default still return a 1.3 MB file Original : 2.2 MB |
I think it makes sense for users to install Linutil if they want to use it for offline commands. |
Since I'm not entirely sure what causes the lengthy launchtime for me, can you guys recommend some tests i could run, or any ideas to help better this? Also, could you share how long it takes for the command to run as well (for some sort of a baseline)? |
@Kingproone, I can think of a few things that might affect the result that you can test.
Those are not really proper tests, but it can give pointers to where the issue(s) might lay in your case. |
I redid the test, with version 08.20 as of now, and based on them I would have to assume that it may have been a time of day issue (based on past experiences, unlikely) and/or something with v 08.01. 1 The original system-using ethernet, installed on ssd(sata)-since the last test i updated the system for latest packages |
Optimise for weight at the expense of compile time, speed and we strip debuging elements
Pull Request
Title
Reduce binary weight to reduce waiting time for slower connection.
Type of Change
Description
Indicate to the compiler to :
Testing
Yes
Impact
Reduce the binary size from 2.2 MB to 1.1 MB, so around 50% reduced weight with no human noticeable impact to performance.
Issue related to PR
Additional Information
Those improvement are stable. There is also unstable improvements that can be added.
Lets also note that we could also create a slim release rather than making this the default. Unsure if there would be any real benefits to be found.
For more information:
https://doc.rust-lang.org/rustc/codegen-options/index.html
Checklist