Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Multi selection and installation #338

Merged
merged 7 commits into from
Sep 19, 2024

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Sep 11, 2024

Pull Request

Implement Multi-Selection and Installation feature

The preview is attached below

multi-selection.mp4

Type of Change

  • New feature
  • UI/UX improvement

Description

This pull request introduces a multi-selection feature that allows users to select multiple commands and execute them in one button press. The commands will be executed one after another in sequential order. Selected commands are marked with an asterisk (*) next to the command name. When executed, the selected commands are concatenated allowing them to run sequentially.

Note

If you want to disable multi-selection for a specific tab it can be specified in the tab_data.toml as multi_selectable = false

  • Press V to toggle multi-selection option.
  • Press Space to select/unselect an command.
  • Press Enter to install all the selected commands.

Testing

Works as described.

Impact

  • Add keybind to enable multi-selection.
  • Adds multi-selection functionality to the command list.
  • Displays an asterisk (*) next to selected commands.
  • Runs the selected commands sequentially by merging them.
  • Should add multi_selectable = false to disable multi selection in specific tab. By default it is enabled.
  • If one script fails the whole execution off all selected commands will not execute.

Additional Information

Warning

The only issue I faced was the commands are executed in the order you select them, so If system update is selected at last it would run the system update at the last only. I was planning on implementing a priority based execution but it needs more work to be done. I planned it for another PR. For now this PR is solely focused on multi selection and execution of commands.

I have disabled multi selection for utilities tab by adding multi_selectable = false as we don't want to execute them with any other commands.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

@jeevithakannan2 jeevithakannan2 force-pushed the multi-selection branch 3 times, most recently from b291a8d to 59c732f Compare September 11, 2024 18:15
@ChrisTitusTech
Copy link
Owner

Sorry for the inconvenience. We had a massive restructure of the codebase to improve future development. Because of this can you update your PR to the new structure. Thank you for your assistance and contribution.

@jeevithakannan2
Copy link
Contributor Author

Conflicts have been resolved

@github-actions github-actions bot added enhancement New feature or request UI/UX labels Sep 18, 2024
@jeevithakannan2 jeevithakannan2 marked this pull request as draft September 19, 2024 02:18
@jeevithakannan2 jeevithakannan2 marked this pull request as ready for review September 19, 2024 02:22
@ChrisTitusTech
Copy link
Owner

Now that is pretty cool. Thanks @jeevithakannan2

@ChrisTitusTech ChrisTitusTech merged commit a747f80 into ChrisTitusTech:main Sep 19, 2024
1 of 2 checks passed
@jeevithakannan2 jeevithakannan2 deleted the multi-selection branch September 20, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants