-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Multi selection and installation #338
Merged
ChrisTitusTech
merged 7 commits into
ChrisTitusTech:main
from
jeevithakannan2:multi-selection
Sep 19, 2024
Merged
feat: Multi selection and installation #338
ChrisTitusTech
merged 7 commits into
ChrisTitusTech:main
from
jeevithakannan2:multi-selection
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2024
jeevithakannan2
force-pushed
the
multi-selection
branch
3 times, most recently
from
September 11, 2024 18:15
b291a8d
to
59c732f
Compare
Sorry for the inconvenience. We had a massive restructure of the codebase to improve future development. Because of this can you update your PR to the new structure. Thank you for your assistance and contribution. |
Conflicts have been resolved |
jeevithakannan2
force-pushed
the
multi-selection
branch
from
September 13, 2024 08:23
3c61f42
to
1fa291d
Compare
This was referenced Sep 15, 2024
Closed
jeevithakannan2
force-pushed
the
multi-selection
branch
from
September 16, 2024 01:28
1fa291d
to
6838811
Compare
jeevithakannan2
force-pushed
the
multi-selection
branch
from
September 16, 2024 02:10
c3dfb00
to
4a1502f
Compare
jeevithakannan2
force-pushed
the
multi-selection
branch
from
September 18, 2024 18:55
c140b0f
to
bc07fcc
Compare
Now that is pretty cool. Thanks @jeevithakannan2 |
ChrisTitusTech
approved these changes
Sep 19, 2024
5 tasks
jeevithakannan2
force-pushed
the
multi-selection
branch
from
September 19, 2024 03:44
d52c4a3
to
67b46ec
Compare
nnyyxxxx
approved these changes
Sep 19, 2024
ChrisTitusTech
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Implement Multi-Selection and Installation feature
The preview is attached below
multi-selection.mp4
Type of Change
Description
This pull request introduces a multi-selection feature that allows users to select multiple commands and execute them in one button press. The commands will be executed one after another in sequential order. Selected commands are marked with an asterisk (*) next to the command name. When executed, the selected commands are concatenated allowing them to run sequentially.
Note
If you want to disable multi-selection for a specific tab it can be specified in the
tab_data.toml
asmulti_selectable = false
Testing
Works as described.
Impact
multi_selectable = false
to disable multi selection in specific tab. By default it is enabled.Additional Information
Warning
The only issue I faced was the commands are executed in the order you select them, so If system update is selected at last it would run the system update at the last only. I was planning on implementing a priority based execution but it needs more work to be done. I planned it for another PR. For now this PR is solely focused on multi selection and execution of commands.
I have disabled multi selection for utilities tab by adding
multi_selectable = false
as we don't want to execute them with any other commands.Checklist