Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One Terminal Script (old) #453

Closed
wants to merge 0 commits into from
Closed

One Terminal Script (old) #453

wants to merge 0 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 18, 2024

Combining the setup scripts for Alacritty and Kitty.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

tabs/applications-setup/tab_data.toml Outdated Show resolved Hide resolved
tabs/applications-setup/terminal-setup.sh Outdated Show resolved Hide resolved
tabs/applications-setup/terminal-setup.sh Outdated Show resolved Hide resolved
@adamperkowski
Copy link
Collaborator

adamperkowski commented Sep 18, 2024

This would break some PRs. I'd say you should draft this and wait until #433 #367 #442 and other ones that conflict get merged.

@ghost
Copy link
Author

ghost commented Sep 18, 2024

@adamperkowski Oh I see, i'll wait

@ghost ghost marked this pull request as draft September 18, 2024 00:57
@nnyyxxxx
Copy link
Contributor

I don't agree with this at all

@nnyyxxxx
Copy link
Contributor

These should be kept separate so they can be maintained better.

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Sep 18, 2024

if you're going to do it this way than you would have to add literally every terminal install script into this that we add into linutil in the future, eventually this will become unusable and unreadable... It's best to keep expanding install scripts out of 1 file. Now this is not the same for my rewrite of the aur helper functionality #382 This PR only includes 2 AUR_Helpers and is very minimal due to that its supposed to be deployed anywhere in any script for Arch Linux users as a way to use their AUR Helpers when necessary.

@ghost
Copy link
Author

ghost commented Sep 18, 2024

@nnyyxxxx right now, only two terminals are being used. Alacritty and Kitty setup covers 90% of the population. I don't think Chris will add konsole or gnome terminal setup here. This is also minimal and can be setup on any distro. Minimal is subjective to each individual.

@nnyyxxxx
Copy link
Contributor

@mashrukk I still don't agree that the terminal scripts should be combined into one script; that is bad and as new terminals get added it will make this PR not good and those terminals will likely have to get added in as well, this will only make the code become unmaintainable over time and also keeping things in separate scripts is better for readability and management..

@ghost
Copy link
Author

ghost commented Sep 18, 2024

@nnyyxxxx I understand.

@ghost ghost marked this pull request as ready for review September 18, 2024 19:06
@ghost ghost closed this Sep 18, 2024
@ghost ghost deleted the term branch September 18, 2024 19:22
@ghost ghost changed the title One Terminal Script One Terminal Script (old) Sep 18, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants