-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One Terminal Script (old) #453
Conversation
@adamperkowski Oh I see, i'll wait |
I don't agree with this at all |
These should be kept separate so they can be maintained better. |
if you're going to do it this way than you would have to add literally every terminal install script into this that we add into linutil in the future, eventually this will become unusable and unreadable... It's best to keep expanding install scripts out of 1 file. Now this is not the same for my rewrite of the aur helper functionality #382 This PR only includes 2 AUR_Helpers and is very minimal due to that its supposed to be deployed anywhere in any script for Arch Linux users as a way to use their AUR Helpers when necessary. |
@nnyyxxxx right now, only two terminals are being used. Alacritty and Kitty setup covers 90% of the population. I don't think Chris will add konsole or gnome terminal setup here. This is also minimal and can be setup on any distro. Minimal is subjective to each individual. |
@mashrukk I still don't agree that the terminal scripts should be combined into one script; that is bad and as new terminals get added it will make this PR not good and those terminals will likely have to get added in as well, this will only make the code become unmaintainable over time and also keeping things in separate scripts is better for readability and management.. |
@nnyyxxxx I understand. |
Combining the setup scripts for Alacritty and Kitty.
Checklist