Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix every issue related to printf #596

Merged

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Sep 21, 2024

Warning: big diff incoming

Read description before looking at the diff, it will explain why so many files are changing.

Going to conflict with #573

Might conflict with #591

Type of Change

  • Refactoring

Description

  1. Increases synergy
  2. Fixes problems with packager not being double quoted and because of that it unquotes itself (shellcheck noticed that)
  3. fixes issues with newlines being created on interactive prints
  4. fixes an issue with the zsh script (shellcheck noticed that)
  5. multiple quoting fixes
  6. multiple formatting fixes

That's about it. Review carefully.

Testing

tested

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

credits

@nnyyxxxx nnyyxxxx marked this pull request as draft September 21, 2024 20:14
core/tabs/applications-setup/browser-setup.sh Outdated Show resolved Hide resolved
core/tabs/utils/auto-login.sh Outdated Show resolved Hide resolved
core/tabs/utils/auto-login.sh Outdated Show resolved Hide resolved
core/tabs/utils/auto-login.sh Outdated Show resolved Hide resolved
core/tabs/utils/numlock.sh Outdated Show resolved Hide resolved
core/tabs/utils/ollama.sh Outdated Show resolved Hide resolved
core/tabs/utils/service-control.sh Outdated Show resolved Hide resolved
core/tabs/utils/timeshift.sh Outdated Show resolved Hide resolved
core/tabs/utils/timeshift.sh Outdated Show resolved Hide resolved
@adamperkowski
Copy link
Collaborator

Looked through every single changed line. Apart from what I've requested, great work. Thanks.

nnyyxxxx and others added 13 commits September 21, 2024 17:24
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
@nnyyxxxx
Copy link
Contributor Author

ready for merge

@nnyyxxxx nnyyxxxx marked this pull request as ready for review September 21, 2024 21:35
@adamperkowski
Copy link
Collaborator

Every single line approved.

@nnyyxxxx nnyyxxxx changed the title increase synergy between scripts increase synergy between scripts && fix every issue related to printf Sep 22, 2024
@nnyyxxxx nnyyxxxx changed the title increase synergy between scripts && fix every issue related to printf fix every issue related to printf && increase synergy between scripts Sep 22, 2024
@nnyyxxxx nnyyxxxx changed the title fix every issue related to printf && increase synergy between scripts fix every issue related to printf Sep 22, 2024
@ChrisTitusTech ChrisTitusTech merged commit cca2660 into ChrisTitusTech:main Sep 22, 2024
2 checks passed
@nnyyxxxx nnyyxxxx deleted the increasesynergybetweenscripts branch September 22, 2024 16:01
@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants