Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto power profiling in arch needs to run an extra command. #655

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

guruswarupa
Copy link
Contributor

@guruswarupa guruswarupa commented Sep 23, 2024

Type of Change

  • Bug fix

Description

Auto power profiling in arch needs to run an extra command. added it to ensure all systems run it before setting power profile.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@lj3954
Copy link
Contributor

lj3954 commented Sep 24, 2024

Other power management software should be offered in linutil as well. auto-cpufreq often significantly degrades performance, has questionable efficacy on modern CPUs, and may even hurt power efficiency in cases, since it's a python program that constantly runs in the background.

Modern AMD laptops are usually advised to run power-profiles-daemon, which is preinstalled on many distros by default, and tlp is a more feature rich option, usually considered the most effective on Intel systems (though it probably shouldn't be in linutil; configuration of the tool is extremely hardware and usecase dependent).

Power management tools also typically induce major conflicts with one another, so these scripts should ensure they don't present the user with the option to install duplicate software, especially not without warning. (This script, for example, should check for the existence of commands like tlp or powerprofilesctl before proceeding)

@ChrisTitusTech
Copy link
Owner

Yeah I've fallen out of love with autocpufreq. I don't use it anymore for any of my laptops, but might as well merge this since it is offered by the utility, but I might remove it altogether.

@ChrisTitusTech ChrisTitusTech merged commit 42e4596 into ChrisTitusTech:main Sep 28, 2024
2 checks passed
@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 28, 2024
@guruswarupa guruswarupa deleted the fix-autocpufreq branch October 3, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants