Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📃 feat: Linux Neptune (Valve's kernel for SteamDeck) installation #683

Merged
merged 11 commits into from
Nov 6, 2024

Conversation

adamperkowski
Copy link
Collaborator

@adamperkowski adamperkowski commented Sep 27, 2024

Type of Change

  • New feature
  • Bug fix

Description

Added a script that installs Linux Neptune and patched required for some components to work on Vanilla Arch. ArchWiki.

Testing

Could not test on the deck so I am unable to confirm if Wi-Fi works properly, but the script itself works.
#269 (comment)

About audio: #269 (comment)

Issues / other PRs related

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

(📃 is a shell script btw)

@cartercanedy
Copy link
Contributor

I think we should implement a confirmation prompt to prevent people from fat fingering on these kinds of significant changes

@cartercanedy
Copy link
Contributor

I've done it before, and I've seen Chris wipe out his nvim cfg on stream, that would be big

@adamperkowski
Copy link
Collaborator Author

@cartercanedy On one hand, I agree, on the other one, Chris says he wants MINIMAL (none) user interaction in shell scripts.
And we have Important Actions with kernel modifications + the script preview so I don't know about this to be honest.

@cartercanedy
Copy link
Contributor

Chris says he wants MINIMAL (none) user interaction in shell scripts

I was thinking about implementing this via a tui integration

@adamperkowski
Copy link
Collaborator Author

I was thinking about implementing this via a tui integration

That might actually be a good idea for tui to automatically detect important actions (we could move these from strings to custom values in toml) and display a popup with confirmation.
Open an issue, please.

core/tabs/system-setup/arch/linux-neptune.sh Outdated Show resolved Hide resolved
core/tabs/system-setup/arch/linux-neptune.sh Outdated Show resolved Hide resolved
core/tabs/system-setup/arch/linux-neptune.sh Outdated Show resolved Hide resolved
@adamperkowski
Copy link
Collaborator Author

I gotta fix my neovim with those whitespaces. Don't know what happened.

@adamperkowski
Copy link
Collaborator Author

@ChrisTitusTech read this: #269

Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add precondition that isolates this to only show on steamdeck

@adamperkowski
Copy link
Collaborator Author

adamperkowski commented Oct 3, 2024

Drafting this because there's a bug in tab_data. It uses the precondition for the whole Arch Linux dir. Fixed.

@adamperkowski adamperkowski marked this pull request as ready for review October 3, 2024 13:04
@adamperkowski adamperkowski changed the title feat: Linux Neptune (Valve's kernel for SteamDeck) installation 📃 feat: Linux Neptune (Valve's kernel for SteamDeck) installation Oct 3, 2024
@adamperkowski adamperkowski added the enhancement New feature or request label Oct 25, 2024
@ChrisTitusTech ChrisTitusTech merged commit 9d1dc35 into ChrisTitusTech:main Nov 6, 2024
4 of 5 checks passed
@nnyyxxxx nnyyxxxx deleted the linux_neptune branch November 6, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making it easier to setup up the Steam Deck OLED on vanilla arch.
5 participants