added waterfox browser #700
Conversation
pacman)
"$AUR_HELPER" -S --needed --noconfirm waterfox-bin
;;
*)
. ./setup-flatpak.sh
flatpak install -y flathub net.waterfox.waterfox
;;its supposed to be like this |
okay |
|
@hexisXz resolve all of these reviews please |
like resole the conversations |
alr i think i did it |
| "$AUR_HELPER" -S --needed --noconfirm waterfox-bin | ||
| ;; | ||
| *) | ||
| . ./setup-flatpak.sh |
There was a problem hiding this comment.
@nnyyxxxx You're the one not testing now.
| . ./setup-flatpak.sh | |
| . ../setup-flatpak.sh |
There was a problem hiding this comment.
@nnyyxxxx You're the one not testing now.
fixed
There was a problem hiding this comment.
@nnyyxxxx You're the one not testing now.
not my job, not my pr, 😆
|
@hexisXz keep this PR focused on 1 thing, move the lapce ide section to a different PR |
lol you are fast. I tried to delete that before anyone could see it but i think i removed it. this is my first time doing a PR so i actually dont know what i am doing. |
|
@hexisXz Please run |
| . ../../common-script.sh | ||
|
|
||
| installWaterfox() { | ||
| if ! command_exists waterfox; then |
There was a problem hiding this comment.
| if ! command_exists waterfox; then | |
| if ! command_exists net.waterfox.waterfox && ! command_exists waterfox; then |
There was a problem hiding this comment.
Add net.waterfox.waterfox for flatpak binaries
Type of Change
Description
Testing
Issues / other PRs related
Additional Information
Checklist
If you see that i edited the Cargo file in core thats because i was trying something out but i reverted it back the the cristitus url so dont worry about that.
also i did test this and it works. (for me at least)