Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: btrfs issue #728

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: btrfs issue #728

merged 1 commit into from
Oct 31, 2024

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Oct 2, 2024 •
edited
Loading

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Testing

  • Timeshift working.

Issues / other PRs related

Additional Information

  • Spent over 4 hours checking out every possible reasons in a VM with crappy internet just for a simple 2 min fix
  • Lesson learnt -> Always check the known issues of the application

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Oct 2, 2024 •
edited
Loading

can you show a screenshot of timeshift working?

@jeevithakannan2
Copy link
Contributor Author

jeevithakannan2 commented Oct 2, 2024 •
edited
Loading

can you show a screenshot of timeshift working?

image

@adamperkowski adamperkowski added the bug Something isn't working label Oct 25, 2024
@ChrisTitusTech ChrisTitusTech merged commit dd10565 into ChrisTitusTech:main Oct 31, 2024
2 checks passed
@jeevithakannan2 jeevithakannan2 deleted the btrfs-fix branch November 1, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

@adamperkowski adamperkowski adamperkowski approved these changes

@nnyyxxxx nnyyxxxx nnyyxxxx approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Archtitus btrfs subvolume issue
4 participants
@jeevithakannan2 @nnyyxxxx @ChrisTitusTech @adamperkowski