Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSUSE to list of linutil added to package managers #820

Merged
merged 20 commits into from
Nov 7, 2024

Conversation

solomoncyj
Copy link
Contributor

Type of Change

  • New feature
  • Bug fix
  • [*] Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

built linutil for OpenSUSE in my Home proj
Now waiting for pr to Devel and Factory to be accepted

Testing

Impact

Issues / other PRs related

  • Resolves #

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

README.md Outdated Show resolved Hide resolved
@adamperkowski
Copy link
Collaborator

Did you include the desktop file and the manpage in your package?
Oh and could you please update the linutil-installer script too?

@solomoncyj
Copy link
Contributor Author

Did you include the desktop file and the manpage in your package? Oh and could you please update the linutil-installer script too?

the latest manpage commits will not appear until a new release is cut. will add the install script. any good way to know if the system is on slowroll or tumblweed?

@adamperkowski
Copy link
Collaborator

any good way to know if the system is on slowroll or tumblweed?

yes. try zypper ls | grep -i tumbleweed. if that doesn't work, there's /etc/os-release. we already have a function in common-script that checks the release.

@adamperkowski
Copy link
Collaborator

the latest manpage commits will not appear until a new release is cut.

in situations like this, i usually do a new pkgrel with the manpage being downloaded separately and then update it on the next release. check out this commit

Copy link

@ormaaj ormaaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost every line has one or more of these issues.

core/tabs/applications-setup/linutil-installer.sh Outdated Show resolved Hide resolved
core/tabs/applications-setup/linutil-installer.sh Outdated Show resolved Hide resolved
core/tabs/applications-setup/linutil-installer.sh Outdated Show resolved Hide resolved
core/tabs/applications-setup/linutil-installer.sh Outdated Show resolved Hide resolved
core/tabs/applications-setup/linutil-installer.sh Outdated Show resolved Hide resolved
core/tabs/applications-setup/linutil-installer.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove the zypper case from installing the crates.io package

README.md Outdated Show resolved Hide resolved
@adamperkowski adamperkowski added the enhancement New feature or request label Oct 27, 2024
@ChrisTitusTech ChrisTitusTech merged commit cb6e0f9 into ChrisTitusTech:main Nov 7, 2024
@solomoncyj solomoncyj deleted the patch-2 branch November 7, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants