🧹 fix+refact(system-cleanup) #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamperkowski
changed the title
adamperkowski
changed the title
Comment on lines
+35
to
+43
| if [ -d /var/tmp ]; then | ||
| "$ESCALATION_TOOL" find /var/tmp -type f -atime +5 -delete | ||
| fi | ||
| if [ -d /tmp ]; then | ||
| "$ESCALATION_TOOL" find /tmp -type f -atime +5 -delete | ||
| fi | ||
| if [ -d /var/log ]; then | ||
| "$ESCALATION_TOOL" find /var/log -type f -name "*.log" -exec truncate -s 0 {} \; | ||
| fi |
There was a problem hiding this comment.
Can we do something like this ? This will not return non zero if the dir is not found
Suggested change
| if [ -d /var/tmp ]; then | |
| "$ESCALATION_TOOL" find /var/tmp -type f -atime +5 -delete | |
| fi | |
| if [ -d /tmp ]; then | |
| "$ESCALATION_TOOL" find /tmp -type f -atime +5 -delete | |
| fi | |
| if [ -d /var/log ]; then | |
| "$ESCALATION_TOOL" find /var/log -type f -name "*.log" -exec truncate -s 0 {} \; | |
| fi | |
| "$ESCALATION_TOOL" find /var/tmp -type f -atime +5 -delete &> /dev/null || true | |
| "$ESCALATION_TOOL" find /tmp -type f -atime +5 -delete &> /dev/null || true | |
| "$ESCALATION_TOOL" find /var/log -type f -name "*.log" -exec truncate -s 0 {} \; &> /dev/null || true |
There was a problem hiding this comment.
We could but if user doesnt have perms for a file (could happen and will happen with /tmp) it'll fail too
There was a problem hiding this comment.
The cmd is escalated so is less likely to fail due to perm err
ChrisTitusTech
approved these changes
Oct 24, 2024
adamperkowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Testing
Works :)
Issues / other PRs related
Checklist