Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Debian && popos gaming deps #859

Merged

Conversation

jeevithakannan2
Copy link
Contributor

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

  • Add git as a dependency because getting version info for lutris requires git
  • Correct package name for libsdl2 => libsdl2-2.0-0
  • Removed redundant update command
  • No confirm installation for lutris
  • Replace unnecessary package install code with unsupported package manager message
  • Remove some comments

Testing

  • Tested on fresh install of debian12 and pop-os 22

Issues / other PRs related

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

core/tabs/system-setup/gaming-setup.sh Outdated Show resolved Hide resolved
@adamperkowski adamperkowski added the bug Something isn't working label Oct 25, 2024
@ChrisTitusTech ChrisTitusTech merged commit a0630e0 into ChrisTitusTech:main Nov 8, 2024
4 checks passed
@jeevithakannan2 jeevithakannan2 deleted the debian-gaming-deps branch November 8, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants