-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact: categorize dev scripts & add zed editor installation #929
base: main
Are you sure you want to change the base?
Conversation
The purpose of all files inside the directory is to setup an application no need to mention it in the file name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to make no conflicts with PR #888
@jeevithakannan2 if there are any other scripts that use && with command_exists please remove all of the &&'s and make a pr |
That suggestion is wrong. |
how so? |
You suggestion is interpreted as command_exists foo1 || command_exists foo2 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This will not check both foo1 and foo2 .It will immediately return 1 if foo1 is not found |
|
im tripping lol |
ig there really is no way to fix that other than manually using && |
* Removes docs and mentions on readme * Update README.md * Update README.md Co-authored-by: Adam Perkowski <[email protected]> * Update linutil.yml * Delete xtask.yml * Update preview.yml * Update README.md --------- Co-authored-by: Chris Titus <[email protected]> Co-authored-by: Adam Perkowski <[email protected]>
* fix create-bootable-usb.sh confirmation prompt * Update core/tabs/utils/create-bootable-usb.sh Co-authored-by: Liam <[email protected]> --------- Co-authored-by: Liam <[email protected]>
* fix: binary download, invalid action inputs * Update preview.yml
Oops accidentally rebased instead of merging main. Will clear this in a minute |
wtf |
Fixed !! |
Rebasing is often preferred, just fyi Too many merges make |
Type of Change
Description
Note
Chores:
Developer-tools
directory todeveloper-tools
(Kind of annoying for developers to hold shift every time when typing D)developer-tools
fromapplication-setup.sh
toapplication.sh
as all the scripts inside the directory is supposed to setup that particular application. No need of mentioning it in the name.Testing
Checklist