Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: categorize dev scripts & add zed editor installation #929

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jeevithakannan2
Copy link
Contributor

Type of Change

  • New feature
  • Refactoring

Description

  • Added zed editor installation script.

Note

Chores:

  • The chores are not related to this PR. Instead of creating a separate PR it was done here itself.
  • Refactor Developer-tools directory to developer-tools (Kind of annoying for developers to hold shift every time when typing D)
  • Refactor file names inside developer-tools from application-setup.sh to application.sh as all the scripts inside the directory is supposed to setup that particular application. No need of mentioning it in the name.
  • The chores are of separate commits @ChrisTitusTech If you wish not to do this we can easily revert the commits.

Testing

  • Tested on arch linux and debian12 without issues.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

The purpose of all files inside the directory is to setup an application no need to mention it in the file name
Copy link
Contributor

@Real-MullaC Real-MullaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to make no conflicts with PR #888

docs/userguide.md Outdated Show resolved Hide resolved
@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Nov 9, 2024

@jeevithakannan2 if there are any other scripts that use && with command_exists please remove all of the &&'s and make a pr

@jeevithakannan2
Copy link
Contributor Author

That suggestion is wrong.

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Nov 9, 2024

how so?

@jeevithakannan2
Copy link
Contributor Author

You suggestion is interpreted as command_exists foo1 || command_exists foo2

@nnyyxxxx

This comment was marked as off-topic.

@nnyyxxxx

This comment was marked as outdated.

@jeevithakannan2
Copy link
Contributor Author

jeevithakannan2 commented Nov 9, 2024

This will not check both foo1 and foo2 .It will immediately return 1 if foo1 is not found

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Nov 9, 2024

removing the && would simplify it since && is redundant due to #762 having both && and not having && is the same but, && is redundant due to #762

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Nov 9, 2024

if one is found why would it need to check the others? - > i misunderstood

This will not check both foo1 and foo2 .It will immediately return 1 if foo1 is not found

@jeevithakannan2
Copy link
Contributor Author

removing the && would simplify it since && is redundant due to #762 having both && and not having && is the same but, && is redundant due to #762

That's what I have explained above. #762 will work as || not as &&

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Nov 9, 2024

i have made a pr to fix this #931 , might as well change it now and reference it in the description of this one

im tripping lol

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Nov 9, 2024

ig there really is no way to fix that other than manually using &&

jeevithakannan2 added a commit to jeevithakannan2/linutil-docs that referenced this pull request Nov 9, 2024
Real-MullaC pushed a commit to Chris-Titus-Docs/linutil-docs that referenced this pull request Nov 9, 2024
Real-MullaC and others added 3 commits November 11, 2024 22:10
* Removes docs and mentions on readme

* Update README.md

* Update README.md

Co-authored-by: Adam Perkowski <[email protected]>

* Update linutil.yml

* Delete xtask.yml

* Update preview.yml

* Update README.md

---------

Co-authored-by: Chris Titus <[email protected]>
Co-authored-by: Adam Perkowski <[email protected]>
* fix create-bootable-usb.sh confirmation prompt

* Update core/tabs/utils/create-bootable-usb.sh

Co-authored-by: Liam <[email protected]>

---------

Co-authored-by: Liam <[email protected]>
* fix: binary download, invalid action inputs

* Update preview.yml
@jeevithakannan2
Copy link
Contributor Author

Oops accidentally rebased instead of merging main. Will clear this in a minute

@nnyyxxxx
Copy link
Contributor

wtf

@jeevithakannan2
Copy link
Contributor Author

Fixed !!

@cartercanedy
Copy link
Contributor

Oops accidentally rebased instead of merging main. Will clear this in a minute

Rebasing is often preferred, just fyi

Too many merges make git log way to complicated to understand/bisect if needed.

@adamperkowski adamperkowski added enhancement New feature or request refactor labels Nov 17, 2024
@adamperkowski adamperkowski changed the title Add Zed editor installation script refact: categorize dev scripts & add zed editor installation Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants