Merge pull request kodecocodes#878 from Vladis92/abs-overflow

Fix abs of hashValue causing overflow
ChristianMoler · May 29, 2019 · 67f00de · 67f00de
2 parents 47456c5 + 721af5d
commit 67f00de
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Hash Table/HashTable.playground/Sources/HashTable.swift b/Hash Table/HashTable.playground/Sources/HashTable.swift
@@ -131,7 +131,7 @@ public struct HashTable<Key: Hashable, Value> {
      Returns the given key's array index.
      */
     private func index(forKey key: Key) -> Int {
-        return abs(key.hashValue) % buckets.count
+        return abs(key.hashValue % buckets.count)
     }
 }
 

diff --git a/Hash Table/README.markdown b/Hash Table/README.markdown
@@ -141,7 +141,7 @@ The hash table does not do anything yet, so let's add the remaining functionalit
 
 ```swift
   private func index(forKey key: Key) -> Int {
-    return abs(key.hashValue) % buckets.count
+    return abs(key.hashValue % buckets.count)
   }
 ```