Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up first part of vortex notebook. #2

Open
wants to merge 1 commit into
base: 2d_vortex
Choose a base branch
from

Conversation

ketch
Copy link

@ketch ketch commented Dec 20, 2023

I didn't go over the whole notebook, but I made some cosmetic improvements to the early part. Note that, due to size and a desire for clean diffs, we store notebooks without output on Github.

There are some formulas in the code that don't match the formulas in the text. I didn't try to fix them since I don't know which is right and which is wrong, but they should be corrected.

Note that num_output_times is not the number of time steps: https://www.clawpack.org/pyclaw/output.html#when-output-is-saved-written

The term "grid size" is potentially confusing since it's often used to refer to $\Delta x$.

Clear output.
Improve formatting.
Clarify some text and comments.
Remove redundant code.
@ketch
Copy link
Author

ketch commented Dec 20, 2023

Also, I wouldn't refer to the plots you've created as "schlieren plots", since you're using a red-white-blue color map.

Since there are no shock waves in this problem, it's probably not best to use a schlieren plot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant