Changed how commands are run to support Python 3, increase stability. #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
commands
andos.system
in favour of thesubprocess
module. Old versions are still supported, so this shouldn't break any code.commands
is completely gone in python 3 andos.system
has long since been replaced bysubprocess
.This adds a lot of stability as the process doesn't need to open a new shell to do anything, one of the major road blocks in getting tests in.
I've tested this in 3.4 and 2.7, but not in older versions (it should work fine as there are fallbacks for everything.)