Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed how commands are run to support Python 3, increase stability. #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kingllama
Copy link
Contributor

Changed commands and os.system in favour of the subprocess module. Old versions are still supported, so this shouldn't break any code. commands is completely gone in python 3 and os.system has long since been replaced by subprocess.

This adds a lot of stability as the process doesn't need to open a new shell to do anything, one of the major road blocks in getting tests in.

I've tested this in 3.4 and 2.7, but not in older versions (it should work fine as there are fallbacks for everything.)

@Christophe31
Copy link
Owner

Christophe31 commented Feb 27, 2017

it looks good to me, I'll pep8 some commas, try it and merge, I hope by next week.

@Christophe31
Copy link
Owner

Christophe31 commented Mar 21, 2017

damned, I forgot you… sorry, I still have this tab open, I didn't forgot totally… =_=

@cmarzullo
Copy link

bump?

@Gerardwx
Copy link

It would be nice to get the updated version into pypi.

@Christophe31
Copy link
Owner

I was sure this project was dead and every body was using tmux nowadays ^^…

I'm sorry but I think you should pip install the fork, as I didn't test anything and don't see a world where I would be using this project again, I feel more honest by not updating it… If someone have an active fork, I may link it in the README…

@Gerardwx
Copy link

That works, but it would be nice just to be able to pip install it. Would you be willing to and @kingllama and/or myself to the pypi screenutils package so one of use could update it. (I'm Gerardw on pypi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants