Search for a range of dates #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nherman71
reviewed
Apr 24, 2024
Chrisvann1
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Also, I am sure the empty field in the line below serves a purpose. But could you briefly explain the empty field at the start of class because I am not sure what that purpose is.
api_response = apiCalls.searchNotes('created_date', "", desired_response, start, end)
There was a problem hiding this comment.
Good catch, didn't consider this
this resolves Chris' desire for a default end as today and default start as sometime in the distant past
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #40
This refactor required changes to four files:
API.md: the "Additional Feature 1: Search notes by note content" section now includes mention of an optional "start" and "end" field for the body sent to the/notes/searchendpointapp.py: search endpoint now supportsstartandendpayload key values, which contain (you guessed it) the start and end dates for the search windows for both modified and created dates searches. Notice that we only check for the values of these keys if the search_field is one of the dates fields, otherwise we don't read it at allapiCalls.py: json for the calls to the search endpoint need to be variable now. if we see that the key is modified or created date, we need to include the start and end values. we do that by setting start and end equal to None type by default, so that they don't need to be included by the caller on the frontend, but can be.frontend.py: now we need to ask the user for two values whenever they run the modified and created date case: the start and end date by which to search.