Improve PMD update procedure #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* config.pmdVersion in package.json now contains the pmd version * the postinstall script to prepares the pmd-package based on pmdVersion * update-pmd script will still update to the latest pmd version
* Bump maven from 3.9.6 to 3.9.9 * Bump cyclondx-maven-plugin from 2.7.11 to 2.8.1 * Exclude pmd-designer * Remove unneeded PMDExamples.setup
adangel
commented
Sep 27, 2024
adangel
commented
Sep 27, 2024
adangel
commented
Sep 27, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the PMD binaries from the repository. That way, a PMD update is just changing the pmdVersion config in package.json.
This means, we don't see PRs with binaries anymore (like #171, #173).
The custom PMD distribution (which contains apex, visualforce, javascript) is built with
npm installornpm ci. To avoid creating the distribution locally over and over again, it will do this only, if the version changes. On GitHub Actions, the build always runs on a fresh checkout. This means, that the dist is always created fresh, fetching all the jars directly from maven-central.