Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roapi一些错误处理函数 #142

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

HIllya51
Copy link
Contributor

@HIllya51 HIllya51 commented Feb 3, 2025

No description provided.

@HIllya51 HIllya51 changed the title roapi for winrt roapi一些错误处理函数 Feb 3, 2025
@HIllya51 HIllya51 closed this Feb 3, 2025
@HIllya51 HIllya51 reopened this Feb 3, 2025
@HIllya51
Copy link
Contributor Author

HIllya51 commented Feb 3, 2025

才看到有个谜之SDK6可链接性的测试,难道前面说的是这个么?我看半天也没看明白这个是怎么一回事,抱歉了。

if (auto pRoFailFastWithErrorContext = try_get_RoFailFastWithErrorContext())
{
pRoFailFastWithErrorContext(hrError);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果从API语义上,RoFailFastWithErrorContext调用后不应该继续执行……

能解释一下原因吗?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没太懂,RoFailFastWithErrorContext不是这次你新增的吗?还是说抓个函数你有其他的参考来源?

Copy link
Contributor Author

@HIllya51 HIllya51 Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不好意思,眼花了。我记得好像参考了哪个来着,奇怪

}
if ((error == S_OK) || (!languageException) || WindowsIsStringEmpty(message))
return FALSE;
// The RoOriginateLanguageException function behaves like RoOriginateError but takes another parameter that stores extra information about the error.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback逻辑为什么不调用RoOriginateError?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

他们都是win8的api,fallback也没用吧...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

他们都是win8的api,fallback也没用吧...

你的注释写着 RoOriginateLanguageException 8.1引入

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实

@mingkuang-Chuyu
Copy link
Collaborator

话说大量扩充这类函数的目的是什么?有实际需要的应用的场景吗?我主要是担心Fallback逻辑错误。
如果你有实际场景这可以验证Fallback是否合理。

@HIllya51
Copy link
Contributor Author

HIllya51 commented Feb 3, 2025

有,不过可能不是很大就是,我在写一个要用winrt的程序,会链接到这些函数里,我希望它能正常在至少在win7上运行,但是因为有这些导入,导致运行不了。但实际上我根本不会运行到会触发这些错误的地方,我会自己进行hr的检查,但就是会链接到这些东西上就很烦了。如果您觉得这些意义不大的话,那我关掉就好了,其实我自己写一个链接进去也能顶掉默认的导入,但我觉得这样有点不舒服。

@HIllya51 HIllya51 closed this Feb 3, 2025
@mingkuang-Chuyu
Copy link
Collaborator

有,不过可能不是很大就是,我在写一个要用winrt的程序,会链接到这些函数里,我希望它能正常在至少在win7上运行,但是因为有这些导入,导致运行不了。但实际上我根本不会运行到会触发这些错误的地方,我会自己进行hr的检查,但就是会链接到这些东西上就很烦了。如果您觉得这些意义不大的话,那我关掉就好了,其实我自己写一个链接进去也能顶掉默认的导入,但我觉得这样有点不舒服。

如果你有实际需要,大批量的提交PR是可以理解的。

@mingkuang-Chuyu mingkuang-Chuyu changed the base branch from master to Fea/YY/PendingPR February 4, 2025 06:03
@mingkuang-Chuyu mingkuang-Chuyu merged commit b90ef53 into Chuyu-Team:Fea/YY/PendingPR Feb 4, 2025
0 of 3 checks passed
mingkuang-Chuyu pushed a commit that referenced this pull request Feb 4, 2025
  - 添加 RoFailFastWithErrorContext
  - 添加 RoOriginateLanguageException
  - 添加 RoTransformError
  - 添加 RoTransformErrorW
  - 添加 RoGetAgileReference
@mingkuang-Chuyu mingkuang-Chuyu linked an issue Feb 4, 2025 that may be closed by this pull request
64 tasks
mingkuang-Chuyu pushed a commit that referenced this pull request Feb 4, 2025
  - 添加 RoFailFastWithErrorContext
  - 添加 RoOriginateLanguageException
  - 添加 RoTransformError
  - 添加 RoTransformErrorW
  - 添加 RoGetAgileReference
mingkuang-Chuyu pushed a commit that referenced this pull request Feb 4, 2025
  - 添加 RoFailFastWithErrorContext
  - 添加 RoOriginateLanguageException
  - 添加 RoTransformError
  - 添加 RoTransformErrorW
  - 添加 RoGetAgileReference
@HIllya51 HIllya51 deleted the roapi branch February 5, 2025 12:31
mingkuang-Chuyu pushed a commit that referenced this pull request Feb 16, 2025
  - 添加 RoFailFastWithErrorContext
  - 添加 RoOriginateLanguageException
  - 添加 RoTransformError
  - 添加 RoTransformErrorW
  - 添加 RoGetAgileReference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The working in progress plan for complementing Windows Runtime Object APIs
2 participants