Display labels and values to ADSREG #51
Conversation
| gfxHeader(applet_name()); | ||
| gfxPos(1, 15); | ||
| gfxPrint(labels[edit_stage]); | ||
| gfxPrint(45 + 18 - digitCount(adsr[edit_stage]) * 6, 15, adsr[edit_stage]); |
There was a problem hiding this comment.
It might be beneficial to the next person to pull the equation of the first arg out into its own variable with a comment. This way there's less logic inline and less to consider while you're reading it.
| int digitCount(int n) { | ||
| int count = 0; | ||
| while (n != 0) { | ||
| n /= 10; // n = n/10 | ||
| ++count; | ||
| } | ||
| return count; | ||
| } |
There was a problem hiding this comment.
Also, by no means a blocker, but I'm of the school of thought where we should avoid imperative-style code as well as potentially infinite loops. My brain is a little fried right now because I've been jumping between PRs all morning, but my instincts are telling me there might be a cleaner and safer way to write this method.
I could 100% be wrong and you could have tried a million things, in which case, ignore my dumb butt :p
There was a problem hiding this comment.
That's pretty much the canonical way to count digits in C. No int exists that will cause an infinite loop, and log10() is much slower.
Adding BigScope App – Changes from pull request Chysn#76 Changes from pull request Chysn#51 Changes from pull request Chysn#105 Changes from pull request Logarhythm1#2
Adding BigScope App – Changes from pull request Chysn#76 Changes from pull request Chysn#51 Changes from pull request Chysn#105 Changes from pull request Logarhythm1#2
Fix transpose in quantizer
Sometimes I want to make a note of exact ADSR values which isn't currently possible so I've added a line that shows them :)