Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIANXKE-178: 'details' column + test fix (message_only handler) #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anx-abruckner
Copy link
Contributor

  • new column 'details' (JSONField) in StatusLog model
  • fixed logging handler for test
  • README update

@zhangshine
Copy link
Contributor

Great PR, but JSONField is not supported by all db engines. And I just want to keep this package small and simple.

@nezhar
Copy link

nezhar commented Feb 24, 2022

Great PR, but JSONField is not supported by all db engines. And I just want to keep this package small and simple.

Would you consider dropping support for outdated Python and Django releases?

The security support of Django 2.2 ends on 01 Apr 2022 and since Django 3.1 the JSONField has been added for all supported database backends: https://docs.djangoproject.com/en/3.1/releases/3.1/#jsonfield-for-all-supported-database-backends

A compatibity matrix can also be added, just in case somebody wants to use the package in combination with an older release, here is an example.

@nezhar
Copy link

nezhar commented Feb 11, 2024

#38 implements the sugestions above with the current acitve versions of Python and Django.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants