Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INSTALL.md: change LLVM description #1318

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

Artoria2e5
Copy link
Contributor

Somehow the changes from #692 did not come with a doc update. The cap at version 13 is given from #574. I did not try to build it with LLVM 14, so I don't know whether it truly doesn't compile or simply fails due to the CMake thing.

Somehow the changes from Cisco-Talos#692 did not come with a doc update. The cap at version 13 is given from Cisco-Talos#574. I did not try to build it with LLVM 14, so I don't know whether it truly doesn't compile or simply fails due to the CMake thing.
Copy link
Contributor

@val-ms val-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying and submitting this fix. Looks good to me.

@val-ms val-ms merged commit 0d4075e into Cisco-Talos:main Jul 26, 2024
@Artoria2e5
Copy link
Contributor Author

Should #574 be closed then? At least the documentation is all good now.

@val-ms
Copy link
Contributor

val-ms commented Jul 29, 2024

Should #574 be closed then? At least the documentation is all good now.

Good catch. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants