Generated resource and datasource for fvSiteAssociated and fvRemoteId #1233

abrahammughal · 2024-06-11T18:53:42Z

akinross · 2024-06-14T06:46:43Z

CI failing on go generate, make sure you run go generate before you push the changes. This ensures that you have not made any manual changes that the go generate command will wipe away.

Please use [ignore] tag for commits that are not related text that need to be in release notes / changes. So Generated resource and datasource for fvSiteAssociated would be a minor_change.
Created fvRemoteId class would be a minor_change. The other would be ignore.

internal/provider/test_constants.go

codecov-commenter · 2024-07-17T22:51:15Z

Codecov Report

Attention: Patch coverage is 86.19173% with 157 lines in your changes missing coverage. Please review.

Project coverage is 84.18%. Comparing base (e45252b) to head (5b6255c).
Report is 9 commits behind head on master.

Files	Patch %	Lines
internal/provider/resource_aci_associated_site.go	83.94%	45 Missing and 25 partials ⚠️
...l/provider/resource_aci_remote_site_id_mappings.go	84.91%	45 Missing and 25 partials ⚠️
...ternal/provider/data_source_aci_associated_site.go	92.85%	6 Missing and 2 partials ⚠️
...rovider/data_source_aci_remote_site_id_mappings.go	93.33%	6 Missing and 2 partials ⚠️
internal/provider/utils.go	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
+ Coverage   84.05%   84.18%   +0.13%     
==========================================
  Files          61       65       +4     
  Lines       17940    19076    +1136     
==========================================
+ Hits        15080    16060     +980     
- Misses       2054     2156     +102     
- Partials      806      860      +54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/resources/associated_site.md

docs/resources/remote_site_id_mappings.md

docs/resources/associated_site.md

gen/definitions/classes.yaml

gen/templates/datasource_test.go.tmpl

internal/provider/test_constants.go

internal/provider/utils.go

akinross · 2024-07-23T06:08:02Z

tests are failing, please check that all test are working

samiib · 2024-08-01T12:57:07Z

gen/generator.go

+					if propertyName == "remoteCtxPcTag" || propertyName == "remotePcTag" {
+						validValue = "defaultValue"
+					}


I agree, we shouldn't hard code property behaviour in the generator. I suggest we provide a way to configure this in the overwrite logic instead of a constant.

samiib · 2024-08-01T12:58:32Z

gen/generator.go

+	// precedenceList := []string{classPkgName, "global"}
+	// for _, precedence := range precedenceList {
+	// 	if classDetails, ok := definitions.Properties[precedence]; ok {
+	// 		for key, value := range classDetails.(map[interface{}]interface{}) {
+	// 			if key.(string) == "resource_required" {
+	// 				for _, v := range value.([]interface{}) {
+	// 					if v.(string) == propertyName {
+	// 						return true
+	// 					}
+	// 				}
+	// 			}
+	// 		}
+	// 	}
+	// }
+	// return false


Yes please, commented out code should be removed.

samiib · 2024-08-01T22:51:59Z

docs/resources/associated_site.md

+* `owner_key` (ownerKey) - (string) The key for enabling clients to own their data for entity correlation.
+* `owner_tag` (ownerTag) - (string) A tag for enabling clients to add their own data. For example, to indicate who created this object.
+* `site_id` (siteId) - (string) A number between 0 and 1000 to identify the primary site being associated.
+  - Default: `0.000000`


Should the default be a decimal value or just a whole number, eg 0?

anvitha-jain · 2024-08-02T17:28:39Z

docs/resources/associated_site.md

+
+  #### Required ####
+
+  * `key` (key) - (string) The key used to uniquely identify this configuration object.


this configuration object -> Associated Site object.

the description for value is not clear.

anvitha-jain · 2024-08-02T17:28:54Z

docs/resources/associated_site.md

+  * `key` (key) - (string) The key used to uniquely identify this configuration object.
+  * `value` (value) - (string) The value of the property.


same as before

anvitha-jain · 2024-08-02T17:29:34Z

docs/resources/remote_site_id_mappings.md

+  * `key` (key) - (string) The key used to uniquely identify this configuration object.
+  * `value` (value) - (string) The value of the property.


same as before

…ations

abrahammughal requested review from akinross and sajagana June 12, 2024 16:50

akinross requested review from lhercot, anvitha-jain, samiib and gmicol June 12, 2024 18:07

akinross requested changes Jun 14, 2024

View reviewed changes

internal/provider/test_constants.go Outdated Show resolved Hide resolved

abrahammughal requested a review from akinross June 18, 2024 16:59

abrahammughal force-pushed the associated_site_and_remote_id branch 3 times, most recently from 6ba7399 to 279aee2 Compare June 25, 2024 22:59

abrahammughal force-pushed the associated_site_and_remote_id branch 2 times, most recently from d46c36f to bed4ce3 Compare July 10, 2024 22:46

abrahammughal force-pushed the associated_site_and_remote_id branch from fa001b0 to bf67ddb Compare July 15, 2024 22:16

akinross requested changes Jul 18, 2024

View reviewed changes

abrahammughal requested a review from akinross July 22, 2024 23:00

samiib requested changes Aug 1, 2024

View reviewed changes

anvitha-jain requested changes Aug 2, 2024

View reviewed changes

abrahammughal force-pushed the associated_site_and_remote_id branch from 05fdd89 to c990d3d Compare August 7, 2024 23:01

abmughal and others added 8 commits August 8, 2024 10:32

Generated resource and datasource for fvSiteAssociated

c0ab7f5

[minor_change] unedited generated file

df7cea0

[minor_change]Fixed attribute and doc issues

c8e51cd

[minor_changes] fixed example in docs

8e56f48

[minor_changes] fixed build check import issues

aefb127

Build check fix

8dd4a94

unfixed build issue

1087c92

Created fvRemoteId class

be818da

abrahammughal added 27 commits August 8, 2024 10:32

[ignore] fixed unclosed brace

b285682

[ignore]

0490a09

[ignore] added datasource required attribute

5c29b62

[ignore] added required attributes pc_tag and vrf_pc_tag

4651b78

[ignore] added modified files

fa41613

[ignore] removed remote_vrf_pc_tag as required attribute

39e56f3

[ignore] changed default value for remote_ctx_pc_tag

8d89bab

[ignore] updated vendor version

63e7b69

[ignore] ran tidy

d55b64a

[ignore] fixed go.sum file

c42ad76

[ignore] fixed default values for site_id in fvSiteAssociated

580930d

[ignore] changed default value for vrf_pc_tag

f21610b

[ignore] fix import example to include the correct dn

62dfaf7

[ignore] temporarily added test constants for testing purposes

96add9f

[ignore] added errCode check

fd06b98

[ignore] fixed parent dependencies in properties.yaml and added annot…

68b5c94

…ations

[ignore] removed unecessary depends_on in test resources

f02e9e8

[ignore] changed default site_id to 0

5b8d0e8

[ignore] fixed not_existing tests

d811ada

[ignore] changed default value for remote_vrf_pc_tag

c345f59

[ignore] removed comment

4cfcb02

[ignore] added documentation about vrf_pc_tag use case

f64db37

[ignore] removed errCode check in utils.go

93de035

[ignore] added seg attributes for fvBD

a10fa27

[ignore] fixed documentation

47bc9a4

[ignore] rebased

a76d205

[ignore] rebased again

3d94130

abrahammughal force-pushed the associated_site_and_remote_id branch from 8c45693 to 3d94130 Compare August 8, 2024 17:33

abrahammughal added 2 commits August 8, 2024 10:43

[ignore] fixed utils.go

c6a20b0

[ignore] removed unecessary test constant

2ebd4a7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generated resource and datasource for fvSiteAssociated and fvRemoteId #1233

Generated resource and datasource for fvSiteAssociated and fvRemoteId #1233

abrahammughal commented Jun 11, 2024

akinross commented Jun 14, 2024 •

edited

Loading

codecov-commenter commented Jul 17, 2024 •

edited

Loading

akinross commented Jul 23, 2024

samiib Aug 1, 2024

samiib Aug 1, 2024

samiib Aug 1, 2024

anvitha-jain Aug 2, 2024

anvitha-jain Aug 2, 2024

anvitha-jain Aug 2, 2024


		#### Required ####

		* `key` (key) - (string) The key used to uniquely identify this configuration object.

		* `key` (key) - (string) The key used to uniquely identify this configuration object.
		* `value` (value) - (string) The value of the property.

Generated resource and datasource for fvSiteAssociated and fvRemoteId #1233

Are you sure you want to change the base?

Generated resource and datasource for fvSiteAssociated and fvRemoteId #1233

Conversation

abrahammughal commented Jun 11, 2024

akinross commented Jun 14, 2024 • edited Loading

codecov-commenter commented Jul 17, 2024 • edited Loading

Codecov Report

akinross commented Jul 23, 2024

samiib Aug 1, 2024

Choose a reason for hiding this comment

samiib Aug 1, 2024

Choose a reason for hiding this comment

samiib Aug 1, 2024

Choose a reason for hiding this comment

anvitha-jain Aug 2, 2024

Choose a reason for hiding this comment

anvitha-jain Aug 2, 2024

Choose a reason for hiding this comment

anvitha-jain Aug 2, 2024

Choose a reason for hiding this comment

akinross commented Jun 14, 2024 •

edited

Loading

codecov-commenter commented Jul 17, 2024 •

edited

Loading