-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(LH-69477): Add user and user_api_token resources #26
Merged
siddhuwarrier
merged 18 commits into
main
from
LH-69477-generate-api-token-for-api-only-user
Aug 30, 2023
Merged
feat(LH-69477): Add user and user_api_token resources #26
siddhuwarrier
merged 18 commits into
main
from
LH-69477-generate-api-token-for-api-only-user
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Terraform devs using the CDO provider to define CDO users and import existing CDO users
…y users' names are changed by CDO
…y users' names are changed by CDO
…LH-69477-generate-api-token-for-api-only-user
2069094
to
6be4d06
Compare
9bee2c9
to
70d4013
Compare
talhazi
reviewed
Aug 30, 2023
talhazi
reviewed
Aug 30, 2023
talhazi
reviewed
Aug 30, 2023
talhazi
reviewed
Aug 30, 2023
talhazi
reviewed
Aug 30, 2023
talhazi
reviewed
Aug 30, 2023
talhazi
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small comments; pls address those before merging
… it clear it's for both read and update
weilueluo
previously requested changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff overall, some comments.
…Output, ReadUserOutput I do not really agree with this, but I'm doing it to keep the peace.
This commit makes two changes: (1) Run acceptance test only when tagged or there is a merge to master, and (2) do not release until after acceptance tests pass. To achieve this, I've combined the two CI pipelines.
Addressed all comments and discussed offline about merging
siddhuwarrier
added a commit
that referenced
this pull request
Sep 29, 2023
https://jira-eng-rtp3.cisco.com/jira/browse/LH-69477 ### Description - Resource: user, user_api_token - Datasource: user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira-eng-rtp3.cisco.com/jira/browse/LH-69477
Description