Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LH-69477): Add user and user_api_token resources #26

Merged
merged 18 commits into from
Aug 30, 2023

Conversation

siddhuwarrier
Copy link
Collaborator

https://jira-eng-rtp3.cisco.com/jira/browse/LH-69477

Description

  • Resource: user, user_api_token
  • Datasource: user

@siddhuwarrier siddhuwarrier force-pushed the LH-69477-generate-api-token-for-api-only-user branch from 2069094 to 6be4d06 Compare August 30, 2023 00:00
@siddhuwarrier siddhuwarrier force-pushed the LH-69477-generate-api-token-for-api-only-user branch from 9bee2c9 to 70d4013 Compare August 30, 2023 00:28
Copy link
Collaborator

@talhazi talhazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments; pls address those before merging

Copy link
Contributor

@weilueluo weilueluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff overall, some comments.

…Output, ReadUserOutput

I do not really agree with this, but I'm doing it to keep the peace.
This commit makes two changes: (1) Run acceptance test only when tagged or there is a merge to master, and (2) do not release until after acceptance tests pass. To achieve this, I've combined the two CI pipelines.
@siddhuwarrier siddhuwarrier dismissed weilueluo’s stale review August 30, 2023 10:26

Addressed all comments and discussed offline about merging

@siddhuwarrier siddhuwarrier merged commit 57ff8de into main Aug 30, 2023
siddhuwarrier added a commit that referenced this pull request Sep 29, 2023
@siddhuwarrier siddhuwarrier deleted the LH-69477-generate-api-token-for-api-only-user branch September 29, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants