Feat cml tmux #143
Merged
Feat cml tmux #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduce a new command 'cml tmux' It allows users to connect to multiple node consoles using 'tmux'. It creates a new 'tmux' session with the lab title and the first 4 characters of the lab ID. The `--group` option offers two grouping choices: - 'panes': Group all connections within a single 'tmux' window. (default) - 'windows': Represent each connection as an individual 'tmux' window. Version 2 only.
Pull Request Test Coverage Report for Build 6700857795
💛 - Coveralls |
xorrkaz
requested changes
Oct 31, 2023
| @@ -1 +1 @@ | |||
| __version__ = "1.4.2" | |||
| __version__ = "1.4.3" | |||
There was a problem hiding this comment.
Please do not bump version yourself.
There was a problem hiding this comment.
Sorry, I based my branch out of master, do you want me to change it to 1.4.2?
There was a problem hiding this comment.
joe-dev should have 1.4.3. I see it in my pull.
| @@ -7,6 +7,7 @@ gunicorn | |||
| idna | |||
| itsdangerous | |||
| Jinja2 | |||
| libtmux | |||
There was a problem hiding this comment.
Is this also required for testing?
There was a problem hiding this comment.
Then it needs to be in test-requirements.txt.
There was a problem hiding this comment.
Committed already!
2b93385
xorrkaz
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are it, time to stop procrastinating and submit that PR for tmux support :)