fix(152): cml ls --all-users display wrong owner

[sgherdao]

alternative fix to #152 (other PR #153):

• inside ls command, make 1 API call to get users and create a mapping owner_id (uuid)-> username
• updated list_lab_table and print_table signatures to take the ownerids_usernames mapping
• add new mock for GET /users in MockCMLServer

[coveralls]

Pull Request Test Coverage Report for Build 9703376108

Details

• 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.03%) to 75.863%

---

Files with Coverage Reduction	New Missed Lines	%
virl/api/cml.py	1	90.7%

Totals
Change from base Build 9625913576:	0.03%
Covered Lines:	1955
Relevant Lines:	2577

---

💛 - Coveralls

[xorrkaz]

I like the simplicity of this approach, but the plugin API needs to change.

[xorrkaz]

I think the API needs to change here as well.

[xorrkaz]

This would also mean a doc change.

[sgherdao]

Another way, to avoid the function signature change, we could set an attribute to the lab object:

    setattr(lab, "owner_username", ownerids_usernames[lab.owner])

or equivalent
lab.owner_username

but I am not sure how you feel about that

[xorrkaz]

No, I don't like this as it changes the underlying CML API. That's more surprising for plugin developers. I like your map approach.

[coveralls]

Pull Request Test Coverage Report for Build 9736239689

Details

• 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.03%) to 75.863%

---

Files with Coverage Reduction	New Missed Lines	%
virl/api/cml.py	1	90.7%

Totals
Change from base Build 9625913576:	0.03%
Covered Lines:	1955
Relevant Lines:	2577

---

💛 - Coveralls

[sgherdao]

Indeed, a bit hackish. I have found some bugs with the users and groups, plus plugin doc is missing. I have the changes staged. Happy to submit another Issue and/or PR or commit here.