Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grammar/wording in README.md #909

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mjbear
Copy link
Contributor

@mjbear mjbear commented Nov 4, 2024

Description

  • Change object-orienting > object-oriented
  • Change structured datastructure > structured data
  • Change familiarized > familiar
  • Remove unnecessary trailing pound/hash # symbol from the guide hyperlink
  • Add the word Genie to describe which package
  • Split a couple long lines

Motivation and Context

Improve and polish the readme text

Impact (If any)

No impact, changes to readme text

Screenshots:

This is for the readme text

❓ Does the changelog need updated for readme changes?

Checklist:

  • I have updated the changelog.
  • I have updated the documentation (If applicable).
  • I have added tests to cover my changes (If applicable).
  • All new and existing tests passed.
  • All new code passed compilation.

@mjbear mjbear requested a review from a team as a code owner November 4, 2024 17:00
@mjbear
Copy link
Contributor Author

mjbear commented Nov 11, 2024

@Taarini @lsheikal
Thoughts on this easy win? 😉 😅

@mjbear
Copy link
Contributor Author

mjbear commented Nov 22, 2024

@Taarini @lsheikal Thoughts on this easy win? 😉 😅

+ @ThomasJRyan since they merged things recently. 😉

Thoughts?

It's been two weeks ... you all were probably busy so I thought I'd tap you all to revisit this.

@ThomasJRyan
Copy link
Collaborator

ThomasJRyan commented Nov 22, 2024

Good call on the tap. It's extremely easy to miss PRs here. Thank you @mjbear

@mjbear
Copy link
Contributor Author

mjbear commented Nov 22, 2024

Good call on the tap. It's extremely easy to miss PRs here. Thank you @mjbear

Understood.
Thank you! @ThomasJRyan

@ThomasJRyan ThomasJRyan merged commit c733815 into CiscoTestAutomation:main Nov 22, 2024
0 of 5 checks passed
@mjbear mjbear deleted the modify_readme branch November 22, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants