-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-10259: Curated event list #1091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add template support for curated event list paragraph - Add styles for curated event list - Add template hook to set translated title for paragraph - Add translations
3 tasks
- Move linkedevents event styles to own file - Better semantic structure for individual templates
jeremysteerio
force-pushed
the
UHF-10259-curated-event-list
branch
from
October 21, 2024 14:24
8223af7
to
0552d5a
Compare
|
teroelonen
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go from my side now 🦖
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-10259
Add fronted files for curated event list paragraph.
Sketch: https://www.figma.com/design/v5YC5vwdlXr1N8RaZ9SMPO/Hel.fi-Ajankohtaissis%C3%A4ll%C3%B6t-(Uutiset)?node-id=3261-57157
What was done
How to install
Test this on an instance of your choice. Note: if you want to run
make fresh
, do it before the next steps.Install the platform config branch:
composer require drupal/helfi_platform_config:dev-UHF-10259-curated-event-list
drush updb -y
. This should install the new paragraph module.drush cr
Install this branch:
composer require drupal/hdbt:dev-UHF-10259-curated-event-list
drush cr
Import translations:
drush locale:check && drush locale:update
drush cr
How to test
Known issues / deviations from the sketch
d.m.Y H:i
and JS locale string format as in sketch. Confirming with design / writing a ticket about this as well.Event testing:
Try you some event combinations. These restrictions should apply:
elo:32916e77-a2fc-4b4b-a605-c84b680bd4c5
in the event search field and choosing the event found. If you try to save the page with this selection, the validation fails it and shows an error message.Multilingual support:
Also:
Continuous documentation
Translations
Other PRs
Platform config