Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X sentry anchor syntax error #1094

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

Arkkimaagi
Copy link
Contributor

UHF-X

What was done

  • Empty hash "" handling was improved in code.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-0000_insert_correct_branch
  • Run make drush-cr

How to test

  • Check that changing urls to and from empty hash no longer causes syntax errors in console.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

@Arkkimaagi Arkkimaagi requested a review from rpnykanen October 28, 2024 09:27
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1094/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants