Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X: Fix webmanifest favicon url #1128

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Conversation

Arkkimaagi
Copy link
Contributor

UHF-X

We get favicon errors on main site due to urls being wrong

What was done

  • Relative webmanifest file was fixed to be static

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_webmanifest_fix
  • Run make drush-cr

How to test

  • Check that favicons from webmanifest are no longer 404
  • Check that code follows our standards

Copy link

github-actions bot commented Dec 7, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1128/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants