Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8770 Unit accessibility information and Unit contact card to global components #759

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Aug 31, 2023

UHF-8770

What was done

  • Add unit contact card and unit accessibility information paragraphs as global components

How to install

  • Test first with some other instance than SOTE. There is a separate PR for SOTE about this.
  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8770_unit_accessibility_information_and_unit_contact_card_to_global_components
  • Update the helfi_platform_config
    • composer require drupal/helfi_platform_config:dev-UHF-8770_unit_accessibility_information_and_unit_contact_card_to_global_components
  • Run make drush-updb drush-cr
  • Check the SOTE specific instructions from the SOTE PR linked below.

How to test

  • Check that you are now able to add paragraphs unit contact card and unit accessibility information to TPR service pages to higher and lower content areas.
  • Check that the paragraphs look correct and functional. There is few screenshots attached on what they should look like when placed in different areas and with different title on the unit contact card. SOTE had these already installed so the styles should be 1:1 from what they were in SOTE instance before.
  • Check that code follows our standards.

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

Screenshot 2023-08-31 at 11 51 39 Screenshot 2023-08-31 at 11 51 28

…_information paragraphs and add some logic so that correct information is displayed on the paragraphs
…drupal-hdbt into UHF-8870_unit_accessibility_information_and_unit_contact_card_to_global_components
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drush updb needs to be run twice to enable paragraphs into the TPR service entity. It should be investigated why is that. Otherwise works nicely and looks good when the pagraphs are added to the TPR service!

…drupal-hdbt into UHF-8770_unit_accessibility_information_and_unit_contact_card_to_global_components
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now! Good job! 🦜

…drupal-hdbt into UHF-8770_unit_accessibility_information_and_unit_contact_card_to_global_components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants