Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8530 remove headings from links #766

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Sep 7, 2023

UHF-8530

  • Links have extra headings
  • Small cards have article elements that are recommended to use for larger content

What was done

  • Heading elements were removed from links and replaced with identical styling
  • Previous service heading bug was fixed
  • article element was removed from tpr-service-channel-group and node-teaser
  • role="article" was removed from two teaser templates so that screen readers do not consider them the same as <article>

How to install

  • Make sure your instance is up and running on latest dev branch of KASKO-instance.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8530_remove_headings_from_links
  • Run make drush-cr

How to test

  • Check that following elements render as they did and no longer contain <article> or role="article" regions.
  • Check that following elements no longer contain semantic headings in the cards and render as they did
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

@Arkkimaagi Arkkimaagi marked this pull request as ready for review September 14, 2023 05:54
@Arkkimaagi Arkkimaagi force-pushed the UHF-8530_remove_headings_from_links branch from e936707 to 32a0361 Compare September 14, 2023 05:55
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work once again! Very nice PR to check 🦖

@Arkkimaagi Arkkimaagi force-pushed the UHF-8530_remove_headings_from_links branch from b85e661 to dbeb0d6 Compare September 15, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants