Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8934: Fix search by address #773

Merged
merged 7 commits into from
Sep 21, 2023
Merged

Conversation

Jussiles
Copy link
Contributor

@Jussiles Jussiles commented Sep 18, 2023

UHF-8934 && UHF-8933

What was done

  • Enable searching schools by either finnish or swedish address on all language pages
  • Remove sorting search result by coordinates instead show swedish schools first when on swedish language page and finnish when on fi or en page
  • Fix total results check for News search. It now brakes the search when there's an invalid url param.

How to install

  • Make sure Kasko and Etusivu instances are up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8934-fix-search-by-address
  • Run make drush-cr

How to test

For KASKO:

  • Create a page in fi, sv and en with School search paragraph
  • Create a page with School search and check that the search is working
  • Make searches with different addresses in fi and sv e.g. Fredrikinkatu 51-53 (Fredriksgatan 51-53), Mannerheimintie 100 (Mannerheimvägen 100), Mäkelänkatu 50 (Backasgatan 50)... Search by address should work on both languages.
  • When your on fi or en translation page you should see the finnish schools first in alphabetical order. When your on sv translation page you should see the swedish schools first in alphabetical order.

FOR ETUSIVU:

@juho-lehmonen juho-lehmonen self-requested a review September 19, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants