Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9032: TPR Unit additional info in accordions #797

Merged
merged 4 commits into from
Oct 19, 2023
Merged

UHF-9032: TPR Unit additional info in accordions #797

merged 4 commits into from
Oct 19, 2023

Conversation

dire
Copy link
Contributor

@dire dire commented Oct 16, 2023 •
edited by teroelonen
Loading

UHF-9032

What was done

  • New TPR data is show as accordions in TPR units pages.

How to install

  • Make sure your instance (some instance with TPR units) is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9032_tpr-unit-accordions
  • Run make drush-cr drush-locale-update

How to test

  • Check some unit pages and that the new TPR fields (Topical, Charges, Further information, Other contact information and Web sites) are shown nicely inside accordions. More info about how the data should be divided into accordions is in the ticket.
  • Check that there is no strange gaps between the accordion heading and the content (should be continuous grey background.
  • Check that the translations work in the accordion headers.
  • Check that the code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

@dire dire marked this pull request as ready for review October 16, 2023 10:16
@dire dire marked this pull request as draft October 16, 2023 10:29
@dire dire marked this pull request as ready for review October 16, 2023 11:02
teroelonen
teroelonen requested changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small clarification needed on the css!

src/scss/06_components/paragraphs/_accordion.scss Outdated Show resolved Hide resolved
@dire dire requested a review from teroelonen October 18, 2023 06:52
teroelonen
teroelonen approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now! Nice work 🦖

@dire dire merged commit 74f4512 into main Oct 19, 2023
1 check passed
@dire dire deleted the UHF-9032_tpr-unit-accordions branch October 19, 2023 05:33
This was referenced Oct 19, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dire @teroelonen