Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-7841: Add Video prefix for iframe title #814

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

xkhaven
Copy link
Contributor

@xkhaven xkhaven commented Oct 27, 2023

UHF-7841

What was done

  • Added "Video: " prefix for remote videos iframe title for accessibility improvements

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-7841_Video_accessibility_updates
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-7841_Video_accessibility_updates
  • Run make drush-updb drush-cr

How to test

  • Add new remote video paragraph and check that "Assistive technology title" has guidance updated for not to use prefix "Video: " on title
  • Remote video's iframe title has "Video: " prefix attached
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

Other PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants