Uhf x button color bug

[Arkkimaagi]

UHF-X

• Dark themed banners have black buttons when they should be white

What was done

• Figured out what was going on.
  • Due to CkEditor5 bugging and creating empty elements, at the last moment before code going live, we "fixed" ckeditor buttons by enforcing new button styles only to apply on non-links and links that have to have href (the cke5 bug does not have hrefs on links)
  • This change was forgotten from similar selector that's used elsewhere using a color helper scss file
  • Due to selector specificity changing to a higher level where it was not supposed to change, colors did not work on buttons as they were planned.
  • Similar rules were added to color helpers and it fixed the problem.

How to install

• Make sure your instance is up and running on latest dev branch.
  • git pull origin dev
  • make fresh
• Update the HDBT theme
  • composer require drupal/hdbt:dev-UHF-X_button_color_bug
• Run make drush-cr

How to test

• Check that buttons work on all theme backgrounds (especially dark banner background colors should have white buttons)
• Check that code follows our standards

Designers review

• This PR does not need designers review

[khalima]

This fix works. Thanks for this, awesome job to find it so fast! 💪 🚀

[teroelonen]

This works correctly for me too 🦖 Great work!