Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9067: Make the results term on unit search paragraph customizable #873

Merged
merged 14 commits into from
Jan 16, 2024
Merged

UHF-9067: Make the results term on unit search paragraph customizable #873

merged 14 commits into from
Jan 16, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jan 8, 2024 •
edited by Arkkimaagi
Loading

UHF-9067

What was done

  • Add check to unit search paragraph if the search results singular or plural terms are set and print them if they are.

How to install

How to test

  • Check testing instructions from the platform-config PR
  • Check the other PRs listed below.
  • Check that code follows our standards.

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

@teroelonen teroelonen mentioned this pull request Jan 8, 2024
Merged
5 tasks
@teroelonen teroelonen mentioned this pull request Jan 9, 2024
Merged
11 tasks
@teroelonen teroelonen marked this pull request as ready for review January 10, 2024 10:21
Arkkimaagi
Arkkimaagi approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, well done on this complex matter. 🍰

@teroelonen teroelonen merged commit a951242 into main Jan 16, 2024
1 check passed
@teroelonen teroelonen deleted the UHF-9067 branch January 16, 2024 08:07
This was referenced Jan 16, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkkimaagi Arkkimaagi Arkkimaagi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @Arkkimaagi