Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9230: Remove unnecessary "-" from after school activity card #894

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

hyrsky
Copy link
Member

@hyrsky hyrsky commented Jan 24, 2024

UHF-9230

What was done

Remove unnecessary '-' from after-school activity card.

image.

The field is a text-field in TPR, so formatting it on Drupal side is a bit fragile. However, with this simple change, the result looks better with current field values.

image

How to install

  • Make sure your KASKO is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9230-after-school-activity-search-card
  • Run make drush-cr

How to test

  • Check that this feature works
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

@hyrsky hyrsky marked this pull request as ready for review January 24, 2024 14:06
Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might also strip other - marks from the data, right? As such these changes were agreed to be too risky and thus the \n stripping was the only change agreed on. I think we can close this PR.

Sorry

@hyrsky hyrsky closed this Jan 24, 2024
@hyrsky hyrsky reopened this Jan 26, 2024
@hyrsky hyrsky requested a review from Arkkimaagi January 26, 2024 08:58
Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After we got more information that the content is not actually free text field, we can proceed with this ugly hack again.

Works as intended, I added an extra space to the replacement string to avoid accidental word combinations just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants