-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-9031 #899
Conversation
…mplify if-statemets
… by adding child accordion chaining thingie
…ton. Single item accordion doesn't need toggle button. Focus back up after closing
@@ -0,0 +1,14 @@ | |||
const Translations = { | |||
open_all: { | |||
fi: 'Avaa kaikki', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this twice in the code, once here and once in .po files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prevent title from flashing with bad translation
…Will be finished for the other libraries in #UHF-9614
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on multiple different scenarios. Good job! 🚀
UHF-9031
What was done
Added toggle all functionality to accordions. Multiple usecases:
How to install
git pull origin dev
make fresh
composer require drupal/hdbt:dev-UHF-9031
make drush-cr
How to test