UHF-9566: Fix deprecated call abs(): Passing null to parameter #1

[hyrsky]

UHF-9566

What was done

total_rows was not defined if $variables['view']->total_rows is zero, since 0 == NULL evaluates to true. This patch ensures that total rows is always defined so templates can use it without checking.

How to reproduce

Find a view with zero results OR find a view and delete its result nodes. Following code triggers the issue:

{% plural total_rows %}

How to install

• Make sure your instance is up and running on latest dev branch.
  • git pull origin dev
  • make fresh
• Update the HDBT theme
  • composer require drupal/hdbt:dev-UHF-9566
• Run make drush-cr

How to test

• Check that code follows our standards

Other PRs

• Fix deprecation error in views-view--job-listing-search.html.twig drupal-helfi-rekry#388
  • previous attempt to fix the issue. However, this is a better solution, since it applies to all templates, not just rekry.

[github-actions]

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/914/html_report/

[khalima]

Good catch, let's merge this! 🚀